headers: Don't let C2Rust process xtimer #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This came up in RIOT-OS/RIOT#20494 -- but whatever triggered things there precisely could break things elsewhere too. Question is, do we treat this as small enough to just slip in through regular updates, or should we have a big formally-breaking change that empties C2Rust's input list and selectively adds items only until all tests build again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xtimer, in a static function, uses
_div_round_upwhich is implemented using C11 generics.As a general rule we should make c2rust more opt-in than opt-out (providing concrete known translatable functions rather than a catch-all conversion), but for now, this should solve the issue.