Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused @types/marked dependency #185

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

thgreasi
Copy link
Contributor

The yarn.lock didn't have any changes b/c the same package is the one used by the easymde version in the lock, so they get deduplicated.
But that's not true for easymde@v2.16.1 (the latest atm) which uses @types/marked@v4.0.1, and b/c of the way that @types/marked@v4.0.0 moved away from export as namespace marked; type of type exports, this atm causes a type clash:

$ npx tsc
node_modules/easymde/types/easymde.d.ts:24:10 - error TS2616: 'marked' can only be imported by using 'import marked = require("../../@types/marked")' or a default import.

24 import { marked } from 'marked';
            ~~~~~~


Found 1 error.

Removing the additional v2 of @types/marked from our node_modules (like this PR does) seems to be fixing it.

@RIP21 RIP21 merged commit 2c675d5 into RIP21:master Jan 17, 2022
@RIP21
Copy link
Owner

RIP21 commented Jan 17, 2022

Thanks for PR! Merged.

@thgreasi thgreasi deleted the drop-types-marked-unused-dependency branch January 17, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants