Update entra_id.rb #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support, for on premsis ADFS where teh tenat id has to be set as ADFS, in which case we shouldnt try to verify as we are not in multi tenant mode.
|
Great catch, I will wait with upgrading till this is in a new release. |
|
bump |
|
@washu The bump came in while I was looking at this, heh. Sorry for the delay; I was on holiday and got back this week but had a big backlog to deal with first. Thanks for the submission. I'd normally encourage people to check the prevailing coding style before making submissions, especially indentation and comment line wrap, and also to make sure that there's test coverage. This is such a simple (yet important) PR though that there's no need for any of that - I'll take care of it before release - so I'll go head and merge this now. Thanks again for the PR! |
pond
approved these changes
Nov 20, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support, for on premsis ADFS where teh tenat id has to be set as ADFS, in which case we shouldnt try to verify as we are not in multi tenant mode.