propose rename of set operation and add symmetric difference #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ties
commented
Nov 28, 2022
ties
commented
- I have updated the changelog in README.md
ties
changed the title
ties
force-pushed
the
feature/propose-rename-of-set-operation
branch
from
392bb66
to
81b98cd
Compare
lolepezy
approved these changes
Nov 28, 2022
| @@ -133,6 +133,9 @@ public ImmutableResourceSet remove(IpResource value) { | |||
| return new Builder(this).remove(value).build(); | |||
| } | |||
|
|
|||
| /** | |||
| * @return $this \cup that$ | |||
There was a problem hiding this comment.
I don't think \cup is more understandable than union :)
| @@ -145,6 +148,9 @@ public ImmutableResourceSet union(ImmutableResourceSet that) { | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * @return $this \cap that$ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.