RDAP Object is Assumed to be an IP on Country Attribute #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelAHM
requested review from
eshryane,
fmurodov,
isvonja and
maggarwal13
as code owners
maggarwal13
reviewed
Dec 6, 2023
whois-api/src/main/java/net/ripe/db/whois/api/rdap/RdapObjectMapper.java
Outdated
Show resolved
Hide resolved
eshryane
changed the title
|
I updated the title to make it clearer, both for the community and ourselves in the future. |
eshryane
reviewed
Dec 6, 2023
whois-api/src/test/java/net/ripe/db/whois/api/rdap/RdapServiceTestIntegration.java
Show resolved
Hide resolved
eshryane
approved these changes
Dec 6, 2023
maggarwal13
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.