Java 21 Support #1440
Merged
Java 21 Support #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eshryane
requested review from
fmurodov,
isvonja,
maggarwal13 and
MiguelAHM
as code owners
MiguelAHM
reviewed
May 30, 2024
MiguelAHM
reviewed
May 30, 2024
[INFO] Annotation processing is enabled because one or more processors were found on the class path. A future release of javac may disable annotation processing unless at least one processor is specified by name (-processor), or a search path is specified (--processor-path, --processor-module-path), or annotation processing is enabled explicitly (-proc:only, -proc:full). Use -Xlint:-options to suppress this message. Use -proc:none to disable annotation processing.
"If you are using JDK >17 and up-to-date libraries like Spring 6, use version 5.1.0 (Release Notes)" according to https://github.com/lukas-krecan/ShedLock
…s/spring-framework#32882 (comment) "These problems come from mixed AspectJ weaving and proxying. In your scenario, you seem to be using @EnableTransactionManagement in AspectJ mode but @EnableCaching in proxy mode. For the time being, you could try to switch @EnableCaching and any other aspect-related functionality to AspectJ mode as well and remove any variant of@EnableAspectJAutoProxy completely, if that is feasible for your application."
|
Integration tests passed |
|
Converting to DRAFT so we don't forget to update the CI build image |
eshryane
commented
Jun 3, 2024
eshryane
commented
Jun 3, 2024
...d/src/test/groovy/net/ripe/db/whois/spec/update/lireditable/BaseLirEditableAttributes.groovy
Show resolved
Hide resolved
eshryane
commented
Jun 3, 2024
whois-scheduler/src/main/java/net/ripe/db/whois/scheduler/SchedulerConfig.java
Show resolved
Hide resolved
eshryane
commented
Jun 3, 2024
whois-api/src/test/resources/applicationContext-api-test-message-dequeue-mock.xml
Show resolved
Hide resolved
eshryane
commented
Jun 3, 2024
whois-api/src/test/resources/applicationContext-api-test-update-request-handler-mock.xml
Show resolved
Hide resolved
eshryane
commented
Jun 3, 2024
eshryane
commented
Jun 3, 2024
whois-scheduler/src/test/resources/applicationContext-scheduler-test-mock.xml
Show resolved
Hide resolved
maggarwal13
approved these changes
Jun 3, 2024
|
Integration tests passed (although I had to retry whois-api a few times) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate Whois to Java 21 LTS version.
Tested
@Aspect/@RetryForannotation is still working (set port.api=80 and Jetty will fail to start).