Fixed Syncupdates HELP Bug #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…recent Jetty may be cause of Syncupdates POST regression).
…1 (more recent Jetty may be cause of Syncupdates POST regression)." This reverts commit 2a067de.
eshryane
requested review from
fmurodov,
isvonja,
maggarwal13 and
MiguelAHM
as code owners
MiguelAHM
reviewed
Apr 26, 2024
whois-api/src/main/java/net/ripe/db/whois/api/httpserver/RewriteEngine.java
Show resolved
Hide resolved
MiguelAHM
approved these changes
Apr 26, 2024
… containing DATA).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request "Use client ip flag as remote address from trusted source" (#1391) introduced a bug where HELP text is returned even if a request contains data. This is because a Rewrite Regex Rule re-wrote an empty path to include the HELP command by default. This is now changed to check for HELP or DATA within the service class itself, and return HELP text only if there is no data.