Add Warning When Password Authentication is used in Mailupdates #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelAHM
requested review from
eshryane,
fmurodov,
isvonja and
maggarwal13
as code owners
maggarwal13
reviewed
Aug 19, 2024
whois-api/src/test/java/net/ripe/db/whois/api/mail/dequeue/MessageServiceTestIntegration.java
Show resolved
Hide resolved
eshryane
changed the title
maggarwal13
reviewed
Aug 21, 2024
whois-api/src/main/java/net/ripe/db/whois/api/mail/dequeue/MessageDequeue.java
Show resolved
Hide resolved
maggarwal13
approved these changes
Aug 21, 2024
maggarwal13
approved these changes
Aug 22, 2024
maggarwal13
reviewed
Oct 21, 2024
| @@ -24,6 +29,13 @@ public class MessageServiceTestIntegration extends AbstractMailMessageIntegratio | |||
| @Autowired | |||
| private MessageService messageService; | |||
|
|
|||
| private static final String FORMATTED_PASSWORD_WARN = """ | |||
| ***Warning: Password authentication will be removed from Mailupdates in a future | |||
There was a problem hiding this comment.
Why not use UpdateMessages.getText()
maggarwal13
reviewed
Oct 21, 2024
| @@ -272,9 +274,19 @@ private void handleMessageInContext(final String messageId, final MimeMessage me | |||
|
|
|||
| private void handleUpdates(final MailMessage mailMessage, final UpdateContext updateContext) { | |||
| final List<Update> updates = updatesParser.parse(updateContext, mailMessage.getContentWithCredentials()); | |||
| addWarnIfPasswordExists(updateContext, updates); | |||
There was a problem hiding this comment.
I thought the story says that it should be controlled via feature flag ? If feature flag is set to false return warning and if set to true return error with default sets to false?
There was a problem hiding this comment.
Put this change behind a feature flag so it can be enabled or disabled independently of Whois releases. If the flag is OFF then return a warning (make this the default). If the flag is ON then return an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.