Skip to content
This repository has been archived by the owner on Sep 8, 2023. It is now read-only.

Update Readme/Credits, Initial Wyze Lock Support #5

Closed
wants to merge 25 commits into from

Conversation

coledeb
Copy link

@coledeb coledeb commented Aug 7, 2021

List of changes made in this pull request:

  • Used @normana10's pull request on @misenhower's original project to introduce initial Wyze Lock support.
  • Updated Readme to add the Wyze Lock to list of supported devices, updated credits section to ensure clarity and not require a continuously growing list of separate entries at the bottom.
  • Bumped version to 0.5.7 and made necessary Changelog updates.

I personally have not been able to test the Wyze Lock functionality, as I do not own a Wyze Lock. User u/nsh02 on the Homebridge subreddit, who has been using my previously created fork/pull request, confirmed that their Wyze Lock is now able to be seen, as well as actioned on after testing this version. I can confirm that I do not see any changed/broken functionality or newly introduced errors in my personal use of this version (sans Wyze Lock of course).

coledeb added 16 commits August 6, 2021 20:35
Updated to 638 to avoid error generated in Homekit log
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
testing in master how dare I
@coledeb
Copy link
Author

coledeb commented Aug 7, 2021

@connorgallopo I tested your proposed fix of replacing the value of HOMEKIT_COLOR_TEMP_MIN with 638 in WyzeMeshLight.js to fix the 'Color Temperature' warnings, however, this introduced errors when I tried running this on my personal Homebridge install. I had no errors when changing colors on bulbs prior to testing that fix, and after testing/updating it generated several near-identical errors (an example included below):

[8/6/2021, 9:38:42 PM] [homebridge-wyze-connected-home-op] This plugin generated a warning from the characteristic 'Color Temperature': characteristic was supplied illegal value: number 511 exceeded maximum of 500. See https://git.io/JtMGR for more info.

As a result, I did not include this in the pull request. I am not an adept programmer, so I am not exactly sure what would be causing those errors for you, or how to resolve them myself.

Running a scene with multiple Wyze Lights could result in issues setting power state, brightness, color, etc. This adds a 0.5s delay between each call.
Running a scene with multiple Wyze Lights could result in issues setting power state, brightness, color, etc. This adds a 0.5s delay between each call.
Running a scene with multiple Wyze Lights could result in issues setting power state, brightness, color, etc. This adds a 0.5s delay between each call.
Testing shortening the delay between calls
Testing shortening delay between calls
Moving logging of light changes to debug for clean up
Moving logging of light changes to debug for clean up
Moving logging of light changes to debug for clean up
Added details for changes in this release
@coledeb
Copy link
Author

coledeb commented Oct 17, 2021

Closing because of further updates

@coledeb coledeb closed this Oct 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant