-
Notifications
You must be signed in to change notification settings - Fork 20
Update Readme/Credits, Initial Wyze Lock Support #5
Conversation
Updated to 638 to avoid error generated in Homekit log
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
Accidentally called previous commit "Wyze Lock v2" when there is only one version of the lock currently.
testing in master how dare I
@connorgallopo I tested your proposed fix of replacing the value of HOMEKIT_COLOR_TEMP_MIN with 638 in WyzeMeshLight.js to fix the 'Color Temperature' warnings, however, this introduced errors when I tried running this on my personal Homebridge install. I had no errors when changing colors on bulbs prior to testing that fix, and after testing/updating it generated several near-identical errors (an example included below): [8/6/2021, 9:38:42 PM] [homebridge-wyze-connected-home-op] This plugin generated a warning from the characteristic 'Color Temperature': characteristic was supplied illegal value: number 511 exceeded maximum of 500. See https://git.io/JtMGR for more info. As a result, I did not include this in the pull request. I am not an adept programmer, so I am not exactly sure what would be causing those errors for you, or how to resolve them myself. |
Running a scene with multiple Wyze Lights could result in issues setting power state, brightness, color, etc. This adds a 0.5s delay between each call.
Running a scene with multiple Wyze Lights could result in issues setting power state, brightness, color, etc. This adds a 0.5s delay between each call.
Running a scene with multiple Wyze Lights could result in issues setting power state, brightness, color, etc. This adds a 0.5s delay between each call.
Testing shortening the delay between calls
Testing shortening delay between calls
Moving logging of light changes to debug for clean up
Moving logging of light changes to debug for clean up
Moving logging of light changes to debug for clean up
Closing because of further updates |
List of changes made in this pull request:
I personally have not been able to test the Wyze Lock functionality, as I do not own a Wyze Lock. User u/nsh02 on the Homebridge subreddit, who has been using my previously created fork/pull request, confirmed that their Wyze Lock is now able to be seen, as well as actioned on after testing this version. I can confirm that I do not see any changed/broken functionality or newly introduced errors in my personal use of this version (sans Wyze Lock of course).