Fixed Odometry step_time calculation #951
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculation for the step_time in the Odometry.cpp was comparing builtin_interfaces/msg/Time nanosec the nanosecond component of that message to rclcpp::Time nanoseconds() which is a absolute measure of time in nanoseconds.
This lead to step_time being negativ, in tern flipping the sign of the resulting odometry.
Additionally the last_time variable was set to msg time before calculation, not after.
I created a private uint32 last_time_ in Odometry.hpp, and switched the calculations to use the msg/Time nanosec value. This will result in bad behaviour if the time difference is larger than 1 sec. But for my use case that is not a Problem