Conversation
scxiao
reviewed
Jan 7, 2026
| else: | ||
| # Qwen only uses gluon pa decode when bs=64 | ||
| return self.paged_attention_triton if ctx.batch_size == 64 else self.paged_attention_asm | ||
| if ATOM_ENABLE_QK_NORM_ROPE_CACHE_QUANT_FUSION: |
Contributor
There was a problem hiding this comment.
should we also make a change for the paged_attention_triton for line 405?
Contributor
Author
There was a problem hiding this comment.
llama and qwen will not trigger the if condition in line 404, check line 132. One problem is that some if conditions here maybe not orthogonal enough for different models.
The accuracy of llama is back to normal with this pr:
Contributor
There was a problem hiding this comment.
But the Qwen3 model failed for the gluon attn here, https://github.com/ROCm/ATOM/actions/runs/20798013041/job/59736412001?pr=56. Do you know why it failed here?
Contributor
Author
There was a problem hiding this comment.
the gluon pa api has been changed in aiter side, but the integration remains unchanged in ATOM. bernard_ps_pa_upstream gave a fix and waiting for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Gluon pa is not fully verified with llama, thus disable this path for llama for now.
Submission Checklist