Fix hipcc exit code when failing #1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch deals with the issue where failed compilations returned a success (exit code 0). Instead we should forward what the compiler returns. |
mangupta
approved these changes
May 24, 2019
|
@mangupta can this PR somehow find the way into the next ROCm release. The wrong return code makes developer the life very hard because CMake is not seeing errors and the ROCm linker is very relaxed and creates binaries even if the device side compile fails. |
|
@psychocoderHPC Yes this should be in the upcoming ROCm 2.6 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.