Add support for extended launch syntax. #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gargrahul
requested changes
Oct 23, 2019
There was a problem hiding this comment.
By when do you think ROCm/hcc-clang-upgrade#183 would be merged ?
mangupta
previously requested changes
Oct 25, 2019
There was a problem hiding this comment.
Building the test fails with the following error message:
hip/tests/src/kernel/hipExtLaunchKernelGGL.cpp:44:5: error: no matching function for call to 'hipExtLaunchKernelGGL'
hipExtLaunchKernelGGL(HipTest::vectorADD, dim3(blocks),
^~~~~~~~~~~~~~~~~~~~~
hip/include/hip/hcc_detail/functional_grid_launch.hpp:177:6: note: candidate function [with Args = <int *, int *, int *, unsigned long>, F = void (*)(int *, int *, int *, unsigned long)] not viable: no overload of 'vectorADD' matching 'void (*)(int *, int *, int *, unsigned long)' for 1st argument
void hipExtLaunchKernelGGL(F kernel, const dim3& numBlocks,
|
@mangupta this won't work until the Clang support is in place (that is the reason for the build failure). Thanks for spotting the typo. |
Change-Id: Ice32dab0d43475fda65c6a910c11416871a8f2ff
gargrahul
dismissed
mangupta’s stale review
Requested changes were addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on ROCm/hcc-clang-upgrade#183. It supersedes #1523.