Implement accurate max block size in hipFuncGetAttributes() #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the calculation was wrong in the first attempt, and I fixed it. however now my own tests are passing. |
|
@jglaser Thanks for the PR. Can you please rebase the PR against the master branch? |
jglaser
force-pushed
the
hipfuncgetattributes
branch
from
d3654b6 to
93c4944
Compare
3 tasks
|
@mangupta It would be great if someone could review, thanks. This will be a blocker once we enable CI for HOOMD blue w/HIP glotzerlab/hoomd-blue#541 |
|
Any progress on this? |
mangupta
previously approved these changes
Feb 26, 2020
mangupta
added
pr:needs_updates
mangupta
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes ensures that the
maxThreadsPerBlockreturned byhipFuncGetAttributesis both a multiple of the warp size and that the register usage of the maximum block does not exceed the number of available registers.Currently targeting the 2.9.x branch because I based it off of that branch (see #1675). Can probably be rebased on master.
Fixes #1662