-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIP Documentation Refactor to incorporate new diataxis based organization and collecting other stale doc PRs #3350
Conversation
|
||
************************************************************************* | ||
Debugging with HIP | ||
************************************************************************* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this entire section is too old.
``HSA_ENABLE_INTERRUPT=0`` causes completion signals to be detected with memory-based | ||
polling, rather than interrupts. | ||
|
||
HIP environment variable summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to environment variables into new page and link.
* :doc:`rocm:/install/linux/install` | ||
* :doc:`rocm:/install/windows/install` | ||
|
||
By default, HIP is installed into /opt/rocm/hip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer accurate, hip is not installed into this directory.
.. note:: | ||
The integrated HIP directed tests will be deprecated in a future release. | ||
|
||
* Build HIP catch tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not call it catch tests, talk to HIP team. They are probably unit tests, functional tests, etc.
* ``__all()``: Returns 1 if all other warp lanes contribute nonzero predicates, otherwise it returns 0 | ||
|
||
To determine if the target platform supports the any/all instruction, you can use the ``hasWarpVote`` | ||
device property or the ``HIP_ARCH_HAS_WARP_VOTE`` compiler definition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
device property or the ``HIP_ARCH_HAS_WARP_VOTE`` compiler definition. | |
device property or the ``HIP_ARCH_HAS_WARP_VOTE`` header file macro definition. |
I think this is the more formal term, I would consult with @MathiasMagnus or @gargrahul .
Note: When using binary code objects is that the number of arguments to the kernel is different on HIP-Clang and NVCC path. Refer to the sample in samples/0_Intro/module_api for differences in the arguments to be passed to the kernel. | ||
|
||
## gfx-arch-specific-kernel | ||
Clang defined '__gfx*__' macros can be used to execute gfx arch specific codes inside the kernel. Refer to the sample 14_gpu_arch in samples/2_Cookbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MathiasMagnus I think we have newer examples available for this now. is that right?
- Add HIP libraries to Library Equivalents doc. - Improve warp cross lane doc, adding sync primitives. - Fix #3312. Use '/' as an absolute path to the file instead of relative.
Is this change still needed? |
Changes in PR#3432 have been merged in Gerrit. |
fee13d6 contains the change. Please raise a new PR in case you find something still missing. |
No description provided.