Update deprecated API list #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyas-streamhpc
requested review from
gandryey,
mangupta and
rakesroy
as code owners
matyas-streamhpc
force-pushed
the
update-deprecated
branch
2 times, most recently
from
8c3cf96
to
89e404a
Compare
neon60
force-pushed
the
update-deprecated
branch
4 times, most recently
from
68f081b
to
0decb31
Compare
matyas-streamhpc
force-pushed
the
update-deprecated
branch
from
0decb31
to
52860cc
Compare
neon60
force-pushed
the
update-deprecated
branch
from
52860cc
to
0decb31
Compare
randyh62
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Left comments. Could use a few tweaks. I like the approach this is taking with regard to the structure, but I think we could pull out more of the autogenerated content if we are going to replace it with hand-crafted content. I also think there is a bit too much redundancy in the content, which doesn't help the user when trying to find content and they can find it in two or more places.
docs/index.md
Outdated
| * {doc}`reference/hip_runtime_api/global_enum_and_defines` | ||
| * {doc}`reference/hip_runtime_api/data_structures` | ||
| * {doc}`reference/hip_runtime_api/files` | ||
| * [HSA runtime API for ROCm](./reference/virtual_rocr) |
There was a problem hiding this comment.
Why is this here? I don't see virtual_rocr in the file list, and is HSA from ROCR-runtime needed here?
There was a problem hiding this comment.
This is a separate issue. Let's discuss later.
randyh62
reviewed
Sep 17, 2024
neon60
force-pushed
the
update-deprecated
branch
2 times, most recently
from
6581e66
to
99c711c
Compare
randyh62
approved these changes
Sep 20, 2024
neon60
force-pushed
the
update-deprecated
branch
2 times, most recently
from
d216558
to
c0faaf7
Compare
neon60
force-pushed
the
docs/develop
branch
from
98f9599
to
73814d1
Compare
neon60
force-pushed
the
update-deprecated
branch
3 times, most recently
from
44c77d4
to
83b83b4
Compare
neon60
force-pushed
the
update-deprecated
branch
from
83b83b4
to
b61aece
Compare
neon60
force-pushed
the
update-deprecated
branch
from
b61aece
to
f55c8dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.