Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OpenGL interop #3641

Open
wants to merge 8 commits into
base: hip_runtime_api_how-to
Choose a base branch
from
Open

Add OpenGL interop #3641

wants to merge 8 commits into from
+712 −1

Conversation

neon60
Copy link
Contributor

@neon60 neon60 commented Oct 16, 2024

No description provided.

@neon60 neon60 added ci:docs-only Only run Read the Docs CI on this PR documentation labels Oct 16, 2024
@matyas-streamhpc matyas-streamhpc self-assigned this Oct 16, 2024
@neon60 neon60 force-pushed the opengl_interop branch 2 times, most recently from 95845c6 to e188501 Compare November 5, 2024 11:16
@neon60 neon60 force-pushed the hip_runtime_api_how-to branch 2 times, most recently from eb41cb1 to 7cb026c Compare November 7, 2024 12:00
randyh62
randyh62 approved these changes Nov 9, 2024
View reviewed changes
Copy link

@randyh62 randyh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I feel like this How to topic could use a little more description of how to use the functions.

docs/how-to/hip_runtime_api/opengl_interop.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/opengl_interop.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/opengl_interop.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/opengl_interop.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/opengl_interop.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/opengl_interop.rst Outdated Show resolved Hide resolved
docs/how-to/hip_runtime_api/opengl_interop.rst Outdated Show resolved Hide resolved
matyas-streamhpc and others added 5 commits November 10, 2024 20:00
@matyas-streamhpc @neon60
Add OpenGL interop
1ed9336 
Add words to wordlist

WIP
@neon60
Update format
80552cc
@matyas-streamhpc @neon60
WIP
ed17827
@neon60 @randyh62
Apply suggestions from code review
486755f 
Co-authored-by: randyh62 <42045079+randyh62@users.noreply.github.com>
@neon60
OpenGL interop functions description update
8af73cf
@neon60 neon60 requested a review from randyh62 November 10, 2024 19:52
neon60 and others added 3 commits November 11, 2024 22:17
@neon60 @randyh62
Update docs/how-to/hip_runtime_api/opengl_interop.rst
0f96bd2 
Co-authored-by: randyh62 <42045079+randyh62@users.noreply.github.com>
@neon60
Add language option
75f07fe
@neon60
WIP
3d752f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randyh62 randyh62 randyh62 approved these changes

@chrispaquot chrispaquot Awaiting requested review from chrispaquot chrispaquot is a code owner

@gandryey gandryey Awaiting requested review from gandryey gandryey is a code owner

@saleelk saleelk Awaiting requested review from saleelk saleelk is a code owner

@mangupta mangupta Awaiting requested review from mangupta mangupta is a code owner

@rakesroy rakesroy Awaiting requested review from rakesroy rakesroy is a code owner

Assignees

@matyas-streamhpc matyas-streamhpc

Labels
ci:docs-only Only run Read the Docs CI on this PR documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neon60 @randyh62 @matyas-streamhpc