-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HIPIFY][Feature] Adding ability to hipify only header files in hipconvertinplace-perl.sh #1474
Comments
mcordery
changed the title
[Feature]:
[Feature]: Adding ability to hipify only header files in hipconvertinplace-perl.sh
May 6, 2024
emankov
changed the title
[Feature]: Adding ability to hipify only header files in hipconvertinplace-perl.sh
[Feature] Adding ability to hipify only header files in hipconvertinplace-perl.sh
May 16, 2024
Hello @mcordery, I don't quite understand the aims of the supposed |
[AMD Official Use Only - AMD Internal Distribution Only]
It would just reduce the time to hipify everything if you didn’t need the repo’s .cu files at all. We’re in the process of porting a bunch of nvidia repos to hip and generally all we need are the header files but sometimes there can be a lot of .cu files either through library code that we don’t need or extensive test files that we don’t need.
From: Evgeny Mankov ***@***.***>
Sent: Thursday, May 16, 2024 11:24 AM
To: ROCm/HIPIFY ***@***.***>
Cc: Cordery, Matthew ***@***.***>; Mention ***@***.***>
Subject: Re: [ROCm/HIPIFY] [Feature] Adding ability to hipify only header files in hipconvertinplace-perl.sh (Issue #1474)
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
Hello @mcordery<https://github.com/mcordery>,
I don't quite understand the aims of the supposed --convert-headers-only.
Is the goal just to reduce the hipification time (hipify-clang, hipify-perl, both?), or is hipification of the source codes is not needed in fact?
—
Reply to this email directly, view it on GitHub<#1474 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEJ5XWL6CRAK2WI6WIDLSW3ZCTTUVAVCNFSM6AAAAABHJWZOYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVHAYTMMJYGU>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
emankov
changed the title
[Feature] Adding ability to hipify only header files in hipconvertinplace-perl.sh
[HIPIFY][Feature] Adding ability to hipify only header files in hipconvertinplace-perl.sh
Jun 26, 2024
emankov
added a commit
to emankov/HIPIFY
that referenced
this issue
Sep 13, 2024
… supplementary hipification scripts - Part 1 - hipconvertinplace-perl.sh + Introduced a new option -filter=all|headers|sources|custom with corresponding sh files + Updated and packaging files correspondingly + [ToDo] Do the same for the rest of supplementary hipification scripts
emankov
added a commit
that referenced
this issue
Sep 16, 2024
[HIPIFY][#1474][Linux][feature] Added a filtering ability for the supplementary hipification scripts - Part 1 - hipconvertinplace-perl.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem Description
In working on porting a library, I've run in to the situation where I'm only making use of the header files in a library (e.g. .h, .cuh) and none of the .cu files which may only be tests or library code that I'm not making use of. It would be nice if hipifyconvertinplace.sh had the ability to take a flag, e.g. --convert-headers-only, that could be passed to findcode.sh. This would provide the benefits of
Operating System
Ubuntu
CPU
Intel
ROCm Version
ROCm 6.0.0
ROCm Component
HIPIFY
Steps to Reproduce
No response
(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support
No response
Additional Information
No response
The text was updated successfully, but these errors were encountered: