Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HIPIFY][Feature] Adding ability to hipify only header files in hipconvertinplace-perl.sh #1474

Open
mcordery opened this issue May 6, 2024 · 2 comments
Assignees
Labels
feature Feature request or implementation question Further information is requested

Comments

@mcordery
Copy link

mcordery commented May 6, 2024

Problem Description

In working on porting a library, I've run in to the situation where I'm only making use of the header files in a library (e.g. .h, .cuh) and none of the .cu files which may only be tests or library code that I'm not making use of. It would be nice if hipifyconvertinplace.sh had the ability to take a flag, e.g. --convert-headers-only, that could be passed to findcode.sh. This would provide the benefits of

  1. reducing the amount of translation time, sometimes significantly
  2. reducing the amount of output that needs to be parsed for errors/warnings about things that need to be addressed.

Operating System

Ubuntu

CPU

Intel

ROCm Version

ROCm 6.0.0

ROCm Component

HIPIFY

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@mcordery mcordery added the feature Feature request or implementation label May 6, 2024
@mcordery mcordery changed the title [Feature]: [Feature]: Adding ability to hipify only header files in hipconvertinplace-perl.sh May 6, 2024
@emankov emankov self-assigned this May 16, 2024
@emankov emankov added the question Further information is requested label May 16, 2024
@emankov emankov changed the title [Feature]: Adding ability to hipify only header files in hipconvertinplace-perl.sh [Feature] Adding ability to hipify only header files in hipconvertinplace-perl.sh May 16, 2024
@emankov
Copy link
Collaborator

emankov commented May 16, 2024

Hello @mcordery,

I don't quite understand the aims of the supposed --convert-headers-only.
Is the goal just to reduce the hipification time (hipify-clang, hipify-perl, both?), or is hipification of the source codes is not needed in fact?

@mcordery
Copy link
Author

mcordery commented May 16, 2024 via email

@emankov emankov changed the title [Feature] Adding ability to hipify only header files in hipconvertinplace-perl.sh [HIPIFY][Feature] Adding ability to hipify only header files in hipconvertinplace-perl.sh Jun 26, 2024
emankov added a commit to emankov/HIPIFY that referenced this issue Sep 13, 2024
… supplementary hipification scripts - Part 1 - hipconvertinplace-perl.sh

+ Introduced a new option -filter=all|headers|sources|custom with corresponding sh files

+ Updated  and packaging files correspondingly

+ [ToDo] Do the same for the rest of supplementary hipification scripts
emankov added a commit that referenced this issue Sep 16, 2024
[HIPIFY][#1474][Linux][feature] Added a filtering ability for the supplementary hipification scripts - Part 1 - hipconvertinplace-perl.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request or implementation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants