Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HIPIFY][#895][#383][hipBLAS-#366][workaround][temporary] Always convert cudaDataType_t to hipDataType under the --use-hip-data-types option #899

Open
emankov opened this issue Jun 2, 2023 · 0 comments
Open

[HIPIFY][#895][#383][hipBLAS-#366][workaround][temporary] Always convert cudaDataType_t to hipDataType under the --use-hip-data-types option #899

emankov opened this issue Jun 2, 2023 · 0 comments
Assignees
@emankov
Labels
feature Feature request or implementation temporary Temporary solution workaround Not a fix, just a workaround

Comments

@emankov
Copy link
Collaborator

emankov commented Jun 2, 2023

  • If --use-hip-data-types is set (unset by default), always convert cudaDataType_t to hipDataType for all HIP libs (ROC libs - to investigate)
  • If --use-hip-data-types is unset (by default) convert cudaDataType_t to the existing own HIP or ROC data types
  • The existing matcher for Data Types substitution should be changed: only cudaDataType_t to hipDataType in mappings should be left; other mappings should go through the matcher
  • Populate the matcher with the enum cudaDataType_t values (currently unsupported)
  • Update all the existing mappings of the cudaDataType_t
  • Update all the related tests
  • Remove this workaround after fixing [hipBLAS-[HIPIFY] Add support for CUDA 11.4 Runtime API functions only #366] and other similar issues in other libs
@emankov emankov added feature Feature request or implementation temporary Temporary solution workaround Not a fix, just a workaround labels Jun 2, 2023
@emankov emankov self-assigned this Jun 2, 2023
emankov added a commit to emankov/HIPIFY that referenced this issue Nov 15, 2023
@emankov
[HIPIFY][SPARSE][tests][fix] CUDA < 8.0 test fixes
9fda5cb 
+ [Reason] `cusparseGetStream` appeared in CUDA 8.0
+ [fix] Set the missing A-version for `cusparseGetStream`
+ Updated synthetic `SPARSE` tests and the regenerated `SPARSE` documentation
+ [TODO][ROCm#899][HIPIFY][ROCm#895][ROCm#383][hipBLAS-ROCm#366][workaround][temporary] Always convert cudaDataType_t to hipDataType under the `--use-hip-data-types` option
@emankov emankov mentioned this issue Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emankov emankov

Labels
feature Feature request or implementation temporary Temporary solution workaround Not a fix, just a workaround
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emankov