Add fin as a submodule #1588
Add fin as a submodule #1588
Conversation
|
In draft state until I verify behavior of Jenkins with git submodules. |
|
Why is fin developed independently? If it needs to be then why doesn't MIOpen use fin with Or is fin more tightly coupled with MIOpen that it needs to build with MIOpen? If so, then why is this in a separate repo? |
|
@JehandadKhan "Tuna Fin Build Test" stage has failed, and I guess that's expected? |
|
Completed work with converting Fin to a submodule. |
There was a problem hiding this comment.
@JehandadKhan it seems to be no functional changes except impacts from Jenkins file on CI?
|
@junliume This removes the Fin code copy from MIOpen, and instead it is tracked as a submodule. This change would remove the diffs we see in MIOpen when we change Fin. MIOpen changes here are for how the Jenkinsfile interacts with and builds the Fin repo. |
| def no_cache = conf.get("no_cache", false) | ||
| def dockerArgs = "--build-arg BUILDKIT_INLINE_CACHE=1 --build-arg PREFIX=${prefixpath} --build-arg GPU_ARCH='${gpu_arch}' --build-arg MIOTENSILE_VER='${miotensile_version}' --build-arg USE_TARGETID='${target_id}' --build-arg USE_MLIR='${mlir_build}' --build-arg USE_FIN='${build_fin}' " | ||
| def dockerArgs = "--build-arg BUILDKIT_INLINE_CACHE=1 --build-arg PREFIX=${prefixpath} --build-arg GPU_ARCH='${gpu_arch}' --build-arg MIOTENSILE_VER='${miotensile_version}' --build-arg USE_TARGETID='${target_id}' --build-arg USE_MLIR='${mlir_build}' " |
There was a problem hiding this comment.
Remove USE_FIN from Dockerfile.
There was a problem hiding this comment.
@cderb Let's remove unused code.
There was a problem hiding this comment.
@atamazov should USE_FIN be removed from everywhere in the repo? I may need to update dockerfile too.
There was a problem hiding this comment.
@junliume I do not know. But removal of USE_FIN='${build_fin}' at this line in Jenkinsfile makes USE_FIN unused in the Dockerfile, so it should be removed.
This PR removes the old fin code which was added verbatim and replaces it with a git submodule. This allows better tracking with the upstream repo which is developed independently.