Implemented readonly-/ramdb preloading #3078
Open
+869
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAHEK7
reviewed
Jul 25, 2024
CAHEK7
reviewed
Jul 25, 2024
CAHEK7
reviewed
Jul 25, 2024
CAHEK7
reviewed
Jul 25, 2024
CAHEK7
approved these changes
Jul 30, 2024
…ed using it as a shortcut
DrizztDoUrden
changed the title
…o stop ongoing prefetches rather than waiting for them
Changed DbPreloadStates to be stored as shared_ptr to prevent them being desctructed while still in use Changed related stop_source to be used correctly Added a mutex to DbPreloadStates dtor to prevent it from executing while it is still being initialized, moved related thread construction under the mutex as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If convolution perf and find dbs have not been started loading yet, handle constructor starts a separate thread that does that. When a db is requested in some library call like find, instead of just creating a new instance it first checks if preload has started and waits for its result if needed.