Adding base class for gtests #3321
Open
+103
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bghimireamd
reviewed
Oct 18, 2024
reidkwja
requested review from
iq136boy and
cderb
and removed request for
JehandadKhan
|
Btw, we are going to get rid of using environment variables #3329 |
CAHEK7
requested changes
Nov 9, 2024
CAHEK7
requested changes
Nov 13, 2024
| // Set environment variables dynamically | ||
| for(const auto& [var, val] : GPU_Conv2dDefault_FP32::get_env_values()) | ||
| { | ||
| miopen::env::setEnvironmentVariable(var, val); |
There was a problem hiding this comment.
I'm afraid it doesn't work for cached env variables.
There was a problem hiding this comment.
Yes, I have been trying different ways to integrate it without changing gtest_common.hpp - which will require changing large numbers of tests.
I am still looking into ways to do so with seamless integration into gtests...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #3135 with a random seed generator + environmental variables saving.