adding 3d bn gtest #3385
Open
adding 3d bn gtest #3385
+402
−162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bghimireamd
requested review from
BrianHarrisonAMD,
junliume and
BradPepersAMD
as code owners
randyspauldingamd
requested changes
Dec 14, 2024
| const | ||
| { | ||
| std::string dimension = std::is_same<TestCase, BN2DTestCase>::value ? "2D" |
There was a problem hiding this comment.
We should start enforcing invalid types with compile-time failures (not just here, but for all of our tests). You could use std::enable_if, but it's so ugly...here's a cleaner idea:
constexpr int dimension = std::is_same<TestCase, BN2DTestCase>::value ? 2
: std::is_same<TestCase, BN3DTestCase>::value ? 3
: -1;
static_assert(dimension > 0);
<snip>
std::ostringstream oss;
oss << tensor_name + "_" + api_name + dimension + "D_" + info.index;
return oss.str();
| // bfp16 | ||
| TEST_P(GPU_BN_CK_BWD_Large_BFP16, DISABLED_BnV2LargeBWDCKbfp16) {} | ||
| TEST_P(GPU_BN_OCL_BWD_Large_BFP16, BnV2LargeBWDOCLbfp16) {} | ||
| // // // bfp16 |
|
|
||
| // fp16 | ||
| // // fp16 |
| testing::ValuesIn({testBNAPIV2})), | ||
| TestNameGenerator<BN3DTestCase>()); | ||
|
|
||
| // // bfp16 |
|
|
||
| // fp32 | ||
| // // fp32 |
| TEST_P(GPU_BN_FWD_Train_Large_FP32, BnV2LargeFWD_TrainCKfp32) {} | ||
| TEST_P(GPU_BNFWDTrainSmall2D_FP32, BnV1SmallFWD_TrainCKfp32) {} | ||
| TEST_P(GPU_BNFWDTrainLarge2D_FP32, BnV2LargeFWD_TrainCKfp32) {} | ||
| TEST_P(GPU_BNFWDTrainSmall3D_FP32, BnV1SmallFWD_TrainC_3DKfp32) {} | ||
|
|
||
| // // // fp64 |
| testing::Combine(testing::ValuesIn(Network3DBN<BN3DTestCase>()), | ||
| testing::ValuesIn({miopenTensorNCDHW}), | ||
| testing::ValuesIn({testBNAPIV1, testBNAPIV2})), | ||
| TestNameGenerator<BN3DTestCase>()); | ||
|
|
||
| // // bfp16 |
| testing::Combine(testing::ValuesIn(Network3DBN<BN3DTestCase>()), | ||
| testing::ValuesIn({miopenTensorNCDHW}), | ||
| testing::ValuesIn({testBNAPIV1, testBNAPIV2})), | ||
| TestNameGenerator<BN3DTestCase>()); | ||
| // // fp32 |
| testing::ValuesIn({miopenTensorNCHW}), | ||
| testing::ValuesIn({testBNAPIV2})), | ||
| TestNameGenerator()); | ||
| TestNameGenerator<BN2DTestCase>()); | ||
| // // fp64 |
| testing::ValuesIn({miopenTensorNCHW, miopenTensorNHWC}), | ||
| testing::ValuesIn({testBNAPIV2})), | ||
| TestNameGenerator()); | ||
| TestNameGenerator<BN2DTestCase>()); |
There was a problem hiding this comment.
clang-format should clean these up as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.