Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding 3d bn gtest #3385

Merged
merged 12 commits into from
Feb 4, 2025
Merged

adding 3d bn gtest #3385

merged 12 commits into from
Feb 4, 2025

Conversation

bghimireamd
Copy link
Contributor

No description provided.

test/gtest/bn.hpp Outdated Show resolved Hide resolved
test/gtest/bn_bwd.cpp Outdated Show resolved Hide resolved

// fp16
// // fp16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra //'s

testing::ValuesIn({testBNAPIV2})),
TestNameGenerator<BN3DTestCase>());

// // bfp16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra //'s


// fp32
// // fp32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra //'s

TEST_P(GPU_BN_FWD_Train_Large_FP32, BnV2LargeFWD_TrainCKfp32) {}
TEST_P(GPU_BNFWDTrainSmall2D_FP32, BnV1SmallFWD_TrainCKfp32) {}
TEST_P(GPU_BNFWDTrainLarge2D_FP32, BnV2LargeFWD_TrainCKfp32) {}
TEST_P(GPU_BNFWDTrainSmall3D_FP32, BnV1SmallFWD_TrainC_3DKfp32) {}

// // // fp64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra //'s

testing::Combine(testing::ValuesIn(Network3DBN<BN3DTestCase>()),
testing::ValuesIn({miopenTensorNCDHW}),
testing::ValuesIn({testBNAPIV1, testBNAPIV2})),
TestNameGenerator<BN3DTestCase>());

// // bfp16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra //'s

testing::Combine(testing::ValuesIn(Network3DBN<BN3DTestCase>()),
testing::ValuesIn({miopenTensorNCDHW}),
testing::ValuesIn({testBNAPIV1, testBNAPIV2})),
TestNameGenerator<BN3DTestCase>());
// // fp32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra //'s

testing::ValuesIn({miopenTensorNCHW}),
testing::ValuesIn({testBNAPIV2})),
TestNameGenerator());
TestNameGenerator<BN2DTestCase>());
// // fp64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra //'s

test/gtest/bn_infer.cpp Show resolved Hide resolved
@BrianHarrisonAMD
Copy link
Contributor

Looks like a new CI error on this PR (possibly dupe name?)

GPU_BNFWDTrainLarge2D_FP64_DISABLED_BnV2LargeFWD_TrainCKfp64_Test

Copy link
Contributor

@BrianHarrisonAMD BrianHarrisonAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bghimireamd bghimireamd merged commit 187216c into develop Feb 4, 2025
30 of 146 checks passed
@bghimireamd bghimireamd deleted the bg/add_3d_bn_gtest branch February 4, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants