Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed all references and pointers to Handle to be const #3402

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Changed all references and pointers to Handle to be const #3402

wants to merge 9 commits into from
+314 −300

Conversation

DrizztDoUrden
Copy link
Contributor

@DrizztDoUrden DrizztDoUrden commented Nov 22, 2024 •
edited
Loading

This allows things like ExecutePrimitive to be called without non-const Handle

@CAHEK7 CAHEK7 mentioned this pull request Nov 22, 2024
Open
BradPepersAMD
BradPepersAMD requested changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@BradPepersAMD BradPepersAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love to see const correctness improved! Need to follow same declaration syntax used for const on other references.

src/adam.cpp Outdated Show resolved Hide resolved
src/include/miopen/execution_context.hpp Outdated Show resolved Hide resolved
src/include/miopen/mlo_internal.hpp Outdated Show resolved Hide resolved
BrianHarrisonAMD
BrianHarrisonAMD approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@BrianHarrisonAMD BrianHarrisonAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Love to see it!

shurale-nkn
shurale-nkn approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@shurale-nkn shurale-nkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianHarrisonAMD BrianHarrisonAMD BrianHarrisonAMD approved these changes

@shurale-nkn shurale-nkn shurale-nkn approved these changes

@CAHEK7 CAHEK7 CAHEK7 approved these changes

@junliume junliume Awaiting requested review from junliume junliume is a code owner

@averinevg averinevg Awaiting requested review from averinevg

@BradPepersAMD BradPepersAMD Awaiting requested review from BradPepersAMD BradPepersAMD is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DrizztDoUrden @CAHEK7 @shurale-nkn @BrianHarrisonAMD @BradPepersAMD