Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Conv] add ck bfp16 for fwd and bwd #3431

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[Conv] add ck bfp16 for fwd and bwd #3431

wants to merge 2 commits into from
+16 −8

Conversation

bghimireamd
Copy link
Contributor

No description provided.

@bghimireamd bghimireamd changed the title add ck bfp16 for fwd and bwd [Conv] add ck bfp16 for fwd and bwd Dec 11, 2024
BradPepersAMD
BradPepersAMD reviewed Dec 28, 2024
View reviewed changes
Copy link
Collaborator

@BradPepersAMD BradPepersAMD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I think important to ensure we have BF16 support on CK kernels. I'd like someone else with more knowledge of what is involved in enabling this to approve as well before this is merged.

@BradPepersAMD
Copy link
Collaborator

What about WRW? Is it already enabled for BF16?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradPepersAMD BradPepersAMD BradPepersAMD left review comments

@BrianHarrisonAMD BrianHarrisonAMD Awaiting requested review from BrianHarrisonAMD BrianHarrisonAMD is a code owner

@junliume junliume Awaiting requested review from junliume junliume is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bghimireamd @BradPepersAMD @xinlipn