Skip to content

MIVisionX-setup.py: git submodule update not needed #3

@jlgreathouse

Description

@jlgreathouse

In MIVisionX-setup.py, line 103 attempts to perform a git submodule update --init --recursive in the protobuf-3.5.2 folder. However, this folder comes from a release .zip file, rather than from a git clone. As such, it is not a git repository (it has no .git folder).

When I try to run this script, it shows the following error:
fatal: Not a git repository (or any of the parent directories): .git

It then goes on because the script does not error checking. I believe the solution here is to simply not include line 110. Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugfixBug fixes to existing features

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions