Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NN Dependencies - Bump future package from 0.18.2 to 1.0.0 #1436

Merged
merged 4 commits into from
Oct 11, 2024

Conversation

hansely
Copy link
Contributor

@hansely hansely commented Oct 4, 2024

Since Python 3.12, the imp module has been deprecated, which caused the following error when running NN tests:

ModuleNotFoundError: No module named 'imp'

This PR upgrades the setup script and python test scripts to install the future package version 1.0.0, which is compatible with the latest Python versions.

@hansely hansely requested review from kiritigowda, rrawther and a team as code owners October 4, 2024 06:54
@kiritigowda
Copy link
Collaborator

@hansely - merge pending CI results

MIVisionX-setup.py Outdated Show resolved Hide resolved
@kiritigowda kiritigowda changed the title Bump future package from 0.18.2 to 1.0.0 NN Dependencies - Bump future package from 0.18.2 to 1.0.0 Oct 8, 2024
@kiritigowda kiritigowda added enhancement New feature or request bugfix Bug fixes to existing features labels Oct 8, 2024
@kiritigowda kiritigowda merged commit 7803f81 into ROCm:develop Oct 11, 2024
12 of 13 checks passed
@hansely hansely deleted the hy/future_update branch October 11, 2024 19:31
kiritigowda added a commit that referenced this pull request Nov 13, 2024
* future version upgrade to 1.0.0

* Revert future version to 0.18.2 for rpm

* Update runNeuralNetworkTests.py

---------

Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
kiritigowda added a commit that referenced this pull request Nov 15, 2024
….2 to 1.0.0 (#1436) (#1449)

* future version upgrade to 1.0.0

* Revert future version to 0.18.2 for rpm

* Update runNeuralNetworkTests.py

---------

Co-authored-by: Hansel Yang <hansyang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fixes to existing features ci:precheckin enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants