OpenVX 1.3 Support #372

kiritigowda · 2020-10-05T20:47:10Z

OpenVX 1.3 CPU Support
Minor Bug Fixes
Vision Conformance Profile

Use CMakeList Variable OPENCL_SUPPORT

cmake -D OPENCL_SUPPORT=OFF ../MIVisionX

Master Merge

* changes for object-array * threshold functions & adding objectarray to ago_util * remap functions * advanced array functions * vxCreateMatrixFromPatternAndOrigin * setImagePixelValues

* createvirtualscalar * vxCreateVirtualConvolution * syntax fix * vxCreateVirtiaulDistribution, scalar syntax fix * vxCreateVirtiaulDistribution, scalar syntax fix * vxCreateVirtiaulMatrix * vxWeightedAverageNode vxuWeightedAverage * vxNonLinearFilterNode, vxuNonLinearFilter * vxLaplacianPyramidNode, vxuLaplacianPyramid * vxLaplacianReconstructNode, vxuLaplacianReconstruct * type fix

* createvirtualscalar * vxCreateVirtualConvolution * syntax fix * vxCreateVirtiaulDistribution, scalar syntax fix * vxCreateVirtiaulDistribution, scalar syntax fix * vxCreateVirtiaulMatrix * vxWeightedAverageNode vxuWeightedAverage * vxNonLinearFilterNode, vxuNonLinearFilter * vxLaplacianPyramidNode, vxuLaplacianPyramid * vxLaplacianReconstructNode, vxuLaplacianReconstruct * type fix * fixes vxGetUserStructNameByEnm and EnumByName * fixes vxCreateObjectArray and vxCreateVirtualObjectArray * conformance test nodes * bug ifx * declaration added * threshold functions * fixes matrix functions * fixes vxSetImagePixelValues * fixes remap functions * threshold typo fix * changed all of objectarray to replicate delay * threshold kernels * weighted average invalid format fix * fixes vxCreateVirtualScalar * fixes vxCReateVirtualConvolution * fixes vxCopyLUT & vxMapLUT * fixing * weightedaverage passed * fix comment * graph/context/refernce+ fixes * target base passes all - vx_context * waitGraph and verifyGraphBase * undo verifyGraphBase * nonlinearfilter passing * latest chanegs * Update CMakeLists.txt * Update ago_platform.h * Update vx_api.cpp * moving #def from VX/include to vx_ext_amd.h * moving #def from VX/include to vx_ext_amd.h * adjusting spaces Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* createvirtualscalar * vxCreateVirtualConvolution * syntax fix * vxCreateVirtiaulDistribution, scalar syntax fix * vxCreateVirtiaulDistribution, scalar syntax fix * vxCreateVirtiaulMatrix * vxWeightedAverageNode vxuWeightedAverage * vxNonLinearFilterNode, vxuNonLinearFilter * vxLaplacianPyramidNode, vxuLaplacianPyramid * vxLaplacianReconstructNode, vxuLaplacianReconstruct * type fix * fixes vxGetUserStructNameByEnm and EnumByName * fixes vxCreateObjectArray and vxCreateVirtualObjectArray * conformance test nodes * bug ifx * declaration added * threshold functions * fixes matrix functions * fixes vxSetImagePixelValues * fixes remap functions * threshold typo fix * changed all of objectarray to replicate delay * threshold kernels * weighted average invalid format fix * fixes vxCreateVirtualScalar * fixes vxCReateVirtualConvolution * fixes vxCopyLUT & vxMapLUT * fixing * weightedaverage passed * fix comment * graph/context/refernce+ fixes * target base passes all - vx_context * waitGraph and verifyGraphBase * undo verifyGraphBase * nonlinearfilter passing * latest chanegs * Update CMakeLists.txt * Update ago_platform.h * Update vx_api.cpp * moving #def from VX/include to vx_ext_amd.h * moving #def from VX/include to vx_ext_amd.h * adjusting spaces * moving things from openvx/include to ext_amd * laplacian update * disable opencl * Update CMakeLists.txt * Update ago_interface.cpp * Update vx_api.cpp * LaplacianReconstruct pass * bug fix * bracket fix * remove debug comments * Update ago_haf_cpu_generic_functions.cpp Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* remove debug comments * Update ago_haf_cpu_generic_functions.cpp * changes to threshold Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* LaplacianPyramid Pass * CMake fix * Revert change Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* Revert change * opencl changes to threshold * threshold with C code Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* fixes meanstddev Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* usernode 20 out of 74 tests pass * removing printf statements * spacing fix Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* spacing fix * adding verification path to fix user node * fixes all tests of the user node Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* fixes all tests of userNode * swapImageHandle - roi=false cases Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* swapImageHandle - roi=false cases * fixes replicateNode object array Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

* fixes LUT failures Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

Upstream Master Merge

…IVisionX into kg/openvx-1.3-port

* wait graph fixed * deadlock debug * deadlock fixed * cmake fix * comments added Co-authored-by: LakshmiKumar23 <kumar.lakshmi1994@gmail.com>

Upstream merge

Upstream master merge

paveltc · 2021-01-12T21:18:04Z

@kiritigowda This PR passed the smoke test.

Merge Upsteam

kiritigowda · 2021-01-14T04:12:31Z

amd_openvx/openvx/ago/ago_util.cpp

@@ -1362,17 +1507,23 @@ int agoGetDataFromDescription(AgoContext * acontext, AgoGraph * agraph, AgoData
 		data->ref.type = VX_TYPE_THRESHOLD;
 		const char *s = strstr(desc, ","); if (!s) return -1;
 		char thresh_type[64], data_type[64];
+		uint32_t input_format, output_format;


@hansely & @LakshmiKumar23 - this section of the code is buggy, try runvx canny to test.

@kiritigowda Found the issue. Emailed the details

Upstream Updates

Upstream merge

rrawther · 2021-02-09T17:27:48Z

@kiritigowda : What is pending for merging this PR?

kiritigowda · 2021-02-09T17:39:56Z

@kiritigowda : What is pending for merging this PR?

@rrawther this is failing the below test, @paveltc needs to push RunVX changes that support threshold to merge this

Running OpenVX Node - canny_edge_detector-1080p-u8
runvx 1.0.0
OK: using AMD OpenVX 1.3.0
terminate called after throwing an instance of 'std::invalid_argument'
  what():  stoi
Aborted (core dumped)

paveltc · 2021-02-09T18:47:31Z

@rrawther and @kiritigowda I'm still working on updating the threshold object in runvx. I'm hoping to have something checked in later today.

Upstream master merge

Co-authored-by: paveltc <pavel.tcherniaev@amd.com>

* CMake * multiply fix * code cleanup

* CMake * canny fix * code cleanup

* fixes GraphROI.Simple & vxMapRemapPatch.MapRandomRemap * Graph.GraphState * fixes Threshold.OnRandom/4/Graph/BINARY/U8/U8 * removing unwanted commits * fixes Threshold.OnRandom/5/Graph/BINARY/S16/U8 * fixes Threshold.OnRandom/7/Graph/RANGE/S16/U8 * removing unnecessary changes

* channel combine fix * merge fix

Upsteam Merge

rrawther · 2021-03-16T20:27:32Z

@kiritigowda I think we should fix some of that codecy warnings since most of them are for unused variables

kiritigowda and others added 30 commits December 17, 2019 14:17

OpenVX 1.3 Headers Added

2d777ed

Temp Changes to build MIVisionX with OpenVX 1.3 Headers

eec7119

Merge branch 'master' into kg/openvx-1.3-port

366a2d9

Master Merge

VX NN 1.3 Port

332afcc

Merge remote-tracking branch 'origin/master' into kg/openvx-1.3-port

fc6abcd

Lk/openvx port 1.3 (#2)

0a487ad

* changes for object-array * threshold functions & adding objectarray to ago_util * remap functions * advanced array functions * vxCreateMatrixFromPatternAndOrigin * setImagePixelValues

changes from Hansel and threshold changes (#7)

f00aaad

* remove debug comments * Update ago_haf_cpu_generic_functions.cpp * changes to threshold Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

OpenVX 1.3 port - Laplacian Pyramid (#8)

6a7bd8c

Laplacian pyramid fix (#9)

28ac48f

* LaplacianPyramid Pass * CMake fix * Revert change Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

OpenVX Port - fix build failures (#10)

25fe764

* Revert change * opencl changes to threshold * threshold with C code Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

mean std deviation fix (#11)

6e42108

* fixes meanstddev Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

user node 20/74 tests passes (#12)

32ef2cd

* usernode 20 out of 74 tests pass * removing printf statements * spacing fix Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

USerNode: All tests pass (#13)

d26e2f2

* spacing fix * adding verification path to fix user node * fixes all tests of the user node Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

SwapImageHandle roi=false cases passes (#14)

17b0c75

* fixes all tests of userNode * swapImageHandle - roi=false cases Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

Merge branch 'master' into kg/openvx-1.3-port

fd089f2

Upstream changes

176adf2

Merge branch 'master' into kg/openvx-1.3-port

d6e7f63

Merge branch 'master' into kg/openvx-1.3-port

076923e

Fixes ReplicateNode-ObjectArray (#17)

1aae035

* swapImageHandle - roi=false cases * fixes replicateNode object array Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

fixes LUT type=S16 failures (#18)

6d04999

* fixes LUT failures Co-authored-by: Hansel Yang <hanselyang123@gmail.com>

Merge branch 'master' into kg/openvx-1.3-port

84dd525

Upstream Master Merge

Merge branch 'kg/openvx-1.3-port' of https://github.com/kiritigowda/M…

3a044b1

…IVisionX into kg/openvx-1.3-port

H/openvx 1.3 port new (#19)

8dbb436

* wait graph fixed * deadlock debug * deadlock fixed * cmake fix * comments added Co-authored-by: LakshmiKumar23 <kumar.lakshmi1994@gmail.com>

Merge branch 'master' into kg/openvx-1.3-port

acc723d

Merge branch 'master' into kg/openvx-1.3-port

33468cb

Merge branch 'master' into kg/openvx-2.3-port

9a19bc3

Upstream merge

Merge branch 'master' into kg/openvx-1.3-port

6184223

kiritigowda added 2 commits January 8, 2021 16:09

Merge branch 'master' into kg/openvx-1.3-port

c1d195a

Upstream merge

Merge branch 'master' into kg/openvx-1.3-port

0a288bd

Upstream master merge

kiritigowda assigned paveltc Jan 12, 2021

Merge branch 'master' into kg/openvx-1.3-port

f120263

Merge Upsteam

kiritigowda commented Jan 14, 2021

View reviewed changes

kiritigowda added 4 commits January 13, 2021 23:23

CXX Flags & OpenVX Version Update

6447c57

Upstream Merge

4a7d552

Merge branch 'master' into kg/openvx-1.3-port

23be2fe

Upstream Updates

Merge branch 'master' into kg/openvx-1.3-port

398d10b

Upstream merge

kiritigowda and others added 12 commits February 9, 2021 10:47

Merge branch 'master' into kg/openvx-1.3-port

0181ccd

Upstream master merge

changed Threshold to support new OpenVX 1.3 format (#38)

60bcf08

Co-authored-by: paveltc <pavel.tcherniaev@amd.com>

Threshold - Update to 1.3

6cade2a

Jenkins - Check Build & Artifacts

84289d6

Tests - Fix platform name

698d731

GPU Fix - multiply gpu (#39)

a0aa933

* CMake * multiply fix * code cleanup

GPU Flow - Canny Fix (#36)

0470e48

* CMake * canny fix * code cleanup

GPU Flow - fixes LUT for data type s16 (#40)

0bf6fc4

GPU Flow - channel combine (#41)

9d3fa77

* channel combine fix * merge fix

Upstream Merge

a653afe

Merge branch 'master' into kg/openvx-1.3-port

bf09593

Upsteam Merge

kiritigowda merged commit 4aeb30f into ROCm:master Mar 15, 2021

kiritigowda deleted the kg/openvx-1.3-port branch March 15, 2021 07:30

kiritigowda restored the kg/openvx-1.3-port branch March 15, 2021 07:30

kiritigowda deleted the kg/openvx-1.3-port branch April 21, 2021 22:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenVX 1.3 Support #372

OpenVX 1.3 Support #372

kiritigowda commented Oct 5, 2020 •

edited

Loading

paveltc commented Jan 12, 2021

kiritigowda Jan 14, 2021

LakshmiKumar23 Jan 14, 2021

rrawther commented Feb 9, 2021

kiritigowda commented Feb 9, 2021

paveltc commented Feb 9, 2021

rrawther commented Mar 16, 2021

OpenVX 1.3 Support #372

OpenVX 1.3 Support #372

Conversation

kiritigowda commented Oct 5, 2020 • edited Loading

paveltc commented Jan 12, 2021

kiritigowda Jan 14, 2021

Choose a reason for hiding this comment

LakshmiKumar23 Jan 14, 2021

Choose a reason for hiding this comment

rrawther commented Feb 9, 2021

kiritigowda commented Feb 9, 2021

paveltc commented Feb 9, 2021

rrawther commented Mar 16, 2021

kiritigowda commented Oct 5, 2020 •

edited

Loading