-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIVisionx - cmake clean up - part2 #946
Merged
kiritigowda
merged 1 commit into
ROCm:develop
from
AryanSalmanpour:as/mivisionx_hip_cmake
Sep 14, 2022
Merged
MIVisionx - cmake clean up - part2 #946
kiritigowda
merged 1 commit into
ROCm:develop
from
AryanSalmanpour:as/mivisionx_hip_cmake
Sep 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiritigowda
reviewed
Sep 14, 2022
kiritigowda
approved these changes
Sep 14, 2022
kiritigowda
added a commit
that referenced
this pull request
Sep 16, 2022
* Zen DNN - Docker & Tests (#924) * Codacy - Fix * Rocal Updates (#921) * rocal updates for tf training * updates for rocal * tf updates and pytorch bug fixes * repo name change * Update README.md * dockerfile update * [rocAL] Fix rocAL Pybind build issue. * [rocAL] Remove unused function in pipeline. * [rocAL] Change rocAL pybind installation from setup.py to wheel. setup.py install is deprecated in python 3.9 * [rocAL] Make TF pets example dataset compatible with tf2. * [rocAL] Change getImageLabels() compatible with tf. * [rocAL] Add fix to pick wheel from dist installation folder. Remove the old installation files in conda environment. * [rocAL] Remove commented statement. Co-authored-by: shobana-mcw <shobana@multicorewareinc.com> * Docker Update (#928) * turboJPEG version update * Update mivisionx-opencl-on-ubuntu20.dockerfile * Zen DNN Updates Sync Co-authored-by: Kiriti Gowda <kiriti.nageshgowda@amd.com> * AMD OpenVX Custom Extension - implementation (#925) * custom node implementation files * fix build errors * custom extension changes for working implementation * add README and documentation * update readme * fix codacy issues and CPU flow * fix cadacy warning * Addressed review comments * minor change * fix formating * amd_migraphx - update readme for extension (#929) * amd_custom - fixes build issue (#935) * fixes build issue * Update CMakeLists.txt * migraphx extension - update the readme(#936) * vx_amd_migraphx - tests (#923) * batch size support for migraphx * changing to accept tensors of all batch sizes * creates file with results * bug fix * changes to singular test cases - mnist and resnet50 * readme updates * resolving PR comments * resolving PR comments * resolving PR comments * Readme update to reflect tot * formatting * fixing typo * readme update * readme update * OpenVX HIP backend - report correct number of CUs for gfx10+ in the logs (#930) * PyTorch docker file - add argument for specifying version (#938) * add argument for specifying PyTorch version for building docker file * add readme for PyTorch * rocAL - Fix ROCAL_USE_USER_GIVEN_SIZE_RESTRICTED (#940) * Docker - codacy fix for pr937 (#942) * rocAL - Adding NCHW FP16 SIMD kernel (#926) * Adding NCHW FP16 SIMD kernel for normalization and buffer copy * Fixed some codestyle issues with FP16 kernel * Using FMA SSE instruction for multiply-add ops * Removed extra spaces * Adding fma flag to rocAL CMakeLists * Adding FP16 intrinsics for buffer copies * Setting rounding mode to _MM_FROUND_TO_ZERO * rocAL - README updates for video unit test (#939) * Add README support for video unit test * Update Readme for video unit test * Minor test_suite fix * Update video unit test Readme * Update Readme * Minor fix * Add test case samples to video unit test README * Modify sample images * Change sample image dimension * Minor change * Minor fix to handle relative input path in video unit test * Minor change * Add correct video reader outputs * MIVisionX - cmake cleanup (#943) * OpenCV EXT - Updates & Tests (#944) * ZenDNN - model compiler (#941) * model compiler - zendnn - mnist layers * bug fix + lrn * layers: batch norm, sum ; bug fixes * fixes lgtm errors * MIVisionx - cmake clean up - part2 (#946) * model compiler - script updates (#945) * MIGraphX Sample - code clean up (#949) * SPACK updates - Turbo JPEG (#948) * Find Turbo JPEG - SPACK Support * Update - Add lib64 support * V2.3 - Updates (#951) Co-authored-by: LakshmiKumar23 <lakshmi.kumar@amd.com> Co-authored-by: shobana-mcw <shobana@multicorewareinc.com> Co-authored-by: Rajy Rawther <Rajy.MeeyakhanRawther@amd.com> Co-authored-by: Aryan Salmanpour <aryan.salmanpour@amd.com> Co-authored-by: swetha097 <59434434+swetha097@users.noreply.github.com> Co-authored-by: Sundar Rajan Vaithiyanathan <99159823+SundarRajan28@users.noreply.github.com> Co-authored-by: Fiona-MCW <70996026+fiona-gladwin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kiritigowda this is the follow-up PR for additional MIVisionX CMake clean-up. The main change here is to switch from {ROCM_PATH}/bin/hipcc to {ROCM_PATH}/llvm/bin/clang++ for compiling HIP kernels.