Skip to content

Conversation

@VeeraRajasekhar
Copy link
Contributor

Description

Please include a brief summary of the changes, relevant motivation and context.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@VeeraRajasekhar
Copy link
Contributor Author

The checkout from github actions also required a safe directory addition. Have fixed it.

Please check the Github action UI, if there are any changes needed with naming and the stages defined, I will make the changes in this pr.

Thanks.

@ipanfilo @wangye805

@leo-amd leo-amd self-requested a review January 26, 2026 16:20
Copy link
Collaborator

@leo-amd leo-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an if: always() block for docker cleanup. Right now the container will persist past the job exit clogging up space and causing other possible issues

@VeeraRajasekhar
Copy link
Contributor Author

VeeraRajasekhar commented Jan 26, 2026

Needs an if: always() block for docker cleanup. Right now the container will persist past the job exit clogging up space and causing other possible issues

@leo-amd is --rm option while running the container takes care of clean up?

Please check this run which is cleaning https://github.com/ROCm/TransformerEngine/actions/runs/21378925978/job/61541373515

@VeeraRajasekhar
Copy link
Contributor Author

@leo-amd this workflow just needs to build, no need of any GPUS's to be present for building. Are there any other pools that I can use of? I don't want to congest our CI runs

@leo-amd
Copy link
Collaborator

leo-amd commented Jan 27, 2026

@VeeraRajasekhar
If the Build step fails or is cancelled, the docker run --rm container will not be removed because the command detached (-d). The container te-aiter-upload will persist.
Since this is running on ephemeral k8s runners, it is not a problem at the moment, but can come to bite us if we use bare metal machines

Needs an if: always() block for docker cleanup. Right now the container will persist past the job exit clogging up space and causing other possible issues

@leo-amd is --rm option while running the container takes care of clean up?

Please check this run which is cleaning https://github.com/ROCm/TransformerEngine/actions/runs/21378925978/job/61541373515

@leo-amd
Copy link
Collaborator

leo-amd commented Jan 27, 2026

@leo-amd this workflow just needs to build, no need of any GPUS's to be present for building. Are there any other pools that I can use of? I don't want to congest our CI runs

Not at the moment, but will eventually use build-only here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants