-
Notifications
You must be signed in to change notification settings - Fork 22
Fixed setting safe.directory for aiter upload #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
The checkout from github actions also required a safe directory addition. Have fixed it. Please check the Github action UI, if there are any changes needed with naming and the stages defined, I will make the changes in this pr. Thanks. |
leo-amd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs an if: always() block for docker cleanup. Right now the container will persist past the job exit clogging up space and causing other possible issues
@leo-amd is --rm option while running the container takes care of clean up?
Please check this run which is cleaning https://github.com/ROCm/TransformerEngine/actions/runs/21378925978/job/61541373515 |
|
@leo-amd this workflow just needs to build, no need of any GPUS's to be present for building. Are there any other pools that I can use of? I don't want to congest our CI runs |
|
@VeeraRajasekhar
|
Not at the moment, but will eventually use build-only here |
Description
Please include a brief summary of the changes, relevant motivation and context.
Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: