Fix inconsistent tensor shapes between shuffle_scale_a16w4 and shuffle_weight_a16w4
#1454
+6
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The expected
srcinput tensor shapes for shuffle_weight_a16w4 (e, n, k) and shuffle_scale_a16w4 (e * n, k) are internally inconsistent: https://github.com/ROCm/aiter/blob/main/aiter/ops/shuffle.pyThis requires the caller in vllm to add an extra view function for the scales to reshape them to match the function calls: https://github.com/ROCm/vllm/pull/808/files#diff-c73528091f2176f6547e24074950962deec4311315fa5e99ef2ca7682680708c
In aiter/355_wip, the shuffle_mxfp4_weight and shuffle_mxfp4_scale functions had matching
srcinput shapes: https://github.com/ROCm/aiter/blob/355_wip/aiter/ops/shuffle.pyTechnical Details
Test Plan
Test Result
Submission Checklist