Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds FP8 (8-bit floating point) support to the CK GEMM tuning infrastructure, expanding beyond the existing INT8 quantization. The changes enable tuning and execution of GEMM operations with FP8 quantized inputs while maintaining the existing INT8 functionality.
Key changes:
- Extended instance generation to support both INT8 and FP8 kernel variants during tuning
- Added FP8 data generation and reference computation paths in the Python tuning script
- Modified the CUDA kernel dispatcher to handle both INT8 and FP8 input types with appropriate template parameters
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| csrc/ck_gemm_a8w8/gen_instances.py | Refactored instance generation to create separate I8 and F8 kernel instances for tuning with appropriate dtype template parameters |
| csrc/ck_gemm_a8w8/gemm_a8w8_tune.py | Added quant_dtype parameter support, FP8 data generation logic, and updated reference computation to handle both I8 and FP8 quantization types |
| csrc/ck_gemm_a8w8/gemm_a8w8_tune.cu | Updated kernel dispatcher to detect input dtype (I8 vs FP8) and dispatch to appropriate kernel templates with matching scale dtypes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
LGTM |
yadaish
previously approved these changes
Jan 8, 2026
yzhou103
reviewed
Jan 9, 2026
Contributor
|
LGTM |
yzhou103
approved these changes
Jan 12, 2026
yadaish
approved these changes
Jan 12, 2026
zhuyuhua-v
pushed a commit
that referenced
this pull request
Jan 14, 2026
* add a8w8 fp8 tune support * add q_dtype_w to deal with different type and refine config csv file --------- Co-authored-by: solin <bingzhou@amd.com> Co-authored-by: yzhou103 <Ying.Zhou2@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist