Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the codebase to accommodate an epilogue class signature change in the composable_kernel library. The main change removes the memory_operation_ parameter from the Run lambda functions and their call sites, replacing the previous split-k handling logic with direct calls to the simplified Run function.
- Removed
memory_operation_parameter fromRunlambdas across multiple GEMM implementations - Eliminated
RunSplitkwrapper functions that conditionally selected memory operations - Updated composable_kernel submodule to a new commit
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| csrc/cktile_gemm_a8w8_bpreshuffle/include/gemm_a8w8_bpreshuffle_cktile_common.cuh | Removed memory_operation parameter from Run lambda and eliminated RunSplitk wrapper |
| csrc/ck_tile_gemm_moe_2stages/include/moe_cktile2stages_common.cuh | Removed memory_operation parameter from Run lambda, eliminated RunSplitk, and updated RunBMem calls |
| csrc/ck_deepgemm/include/deepgemm_common.cuh | Removed memory_operation parameter from Run lambda and eliminated RunSplitk wrapper |
| 3rdparty/composable_kernel | Updated submodule commit to align with upstream epilogue signature changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
valarLip
approved these changes
Jan 9, 2026
zhuyuhua-v
pushed a commit
that referenced
this pull request
Jan 14, 2026
* maybe fix build * update ck submodule past 3359 * Update to ROCm/composable_kernel@e339101 --------- Co-authored-by: Ding, Yi <yi.ding@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Companion to ROCm/composable_kernel#3359
Technical Details
Epilogue class signature change
Test Plan
CI (locally it takes too long to compile)
Test Result
All checks pass
Submission Checklist