Support profiler pa and reduce kernel and remove p99 to use test_common#1787
Merged
ZhangLirong-amd merged 12 commits intomainfrom Jan 12, 2026
Merged
Support profiler pa and reduce kernel and remove p99 to use test_common#1787ZhangLirong-amd merged 12 commits intomainfrom
ZhangLirong-amd merged 12 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the performance profiling functionality in the PA (Paged Attention) test suite. The changes replace a percentile-based benchmarking approach with PyTorch profiler-based kernel time breakdown, allowing for more detailed analysis of PA kernel and reduce kernel execution times.
Key changes:
- Replaces
benchmark_with_percentilewithprofile_kernel_breakdownto provide kernel-level timing breakdown - Renames
--use_p99flag to--profilefor clarity - Updates performance comparison output to show kernel-specific timing ratios
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ZhangLirong-amd
force-pushed
the
zlr/pa_pa_fix
branch
from
9a58227 to
959de59
Compare
dbyoung18
reviewed
Jan 8, 2026
valarLip
previously approved these changes
Jan 10, 2026
Signed-off-by: Double Young <yang.yang2@amd.com>
dbyoung18
force-pushed
the
zlr/pa_pa_fix
branch
from
23e9507 to
495624d
Compare
valarLip
approved these changes
Jan 12, 2026
zhuyuhua-v
pushed a commit
that referenced
this pull request
Jan 14, 2026
…on (#1787) * Support profiler pa and reduce kernel and remove p99 method to use test_common * format code * add more info for pa * reformat * add bs info * use torch schedule to wram up * remove some feature in csv * refactor * test(paps): enhance paps ut Signed-off-by: Double Young <yang.yang2@amd.com> * fix(paps): fix format * fix(paps): fix format * fix(paps): fix format --------- Signed-off-by: Double Young <yang.yang2@amd.com> Co-authored-by: Double Young <yang.yang2@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
To better breakdown Pa kernel time and reduce kernel time, we use profile to breakdown
python op_tests/test_pa_ps.py --profile