Skip to content

update AITER_ASM_DIR#1812

Merged
amd-ruitang3 merged 1 commit intomainfrom
mdf_unit_test
Jan 13, 2026
Merged

update AITER_ASM_DIR#1812
amd-ruitang3 merged 1 commit intomainfrom
mdf_unit_test

Conversation

@amd-ruitang3
Copy link
Contributor

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the AITER_ASM_DIR environment variable to point to a base path without the architecture name, then dynamically appends the architecture name using the get_gpu_arch() function. This change makes the configuration more flexible by automatically selecting the correct architecture-specific subdirectory at runtime.

Changes:

  • Updated AITER_ASM_DIR path structure to remove hardcoded architecture name
  • Modified C++ code to dynamically construct architecture-specific paths using get_gpu_arch()
  • Updated documentation to reflect the new path structure

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
op_tests/cpp/mha/README.md Updated documentation to remove {arch_name}/ from the AITER_ASM_DIR export example
csrc/py_itfs_cu/asm_fmoe.cu Modified FMoeKernel constructor to dynamically build path with architecture name
csrc/include/aiter_hip_common.h Updated AiterAsmKernel constructor to dynamically build path with architecture name, added forward declaration of get_gpu_arch()
aiter/jit/core.py Simplified AITER_ASM_DIR definition to base path without architecture subdirectory

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@amd-ruitang3 amd-ruitang3 merged commit d25bff4 into main Jan 13, 2026
23 checks passed
@amd-ruitang3 amd-ruitang3 deleted the mdf_unit_test branch January 13, 2026 09:01
zhuyuhua-v pushed a commit that referenced this pull request Jan 14, 2026
yzhou103 pushed a commit that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants