Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the AITER_ASM_DIR environment variable to point to a base path without the architecture name, then dynamically appends the architecture name using the get_gpu_arch() function. This change makes the configuration more flexible by automatically selecting the correct architecture-specific subdirectory at runtime.
Changes:
- Updated AITER_ASM_DIR path structure to remove hardcoded architecture name
- Modified C++ code to dynamically construct architecture-specific paths using
get_gpu_arch() - Updated documentation to reflect the new path structure
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
op_tests/cpp/mha/README.md |
Updated documentation to remove {arch_name}/ from the AITER_ASM_DIR export example |
csrc/py_itfs_cu/asm_fmoe.cu |
Modified FMoeKernel constructor to dynamically build path with architecture name |
csrc/include/aiter_hip_common.h |
Updated AiterAsmKernel constructor to dynamically build path with architecture name, added forward declaration of get_gpu_arch() |
aiter/jit/core.py |
Simplified AITER_ASM_DIR definition to base path without architecture subdirectory |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
junhaha666
approved these changes
Jan 13, 2026
zhuyuhua-v
pushed a commit
that referenced
this pull request
Jan 14, 2026
yzhou103
pushed a commit
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist