Conversation
1 task
Contributor
Author
|
@slippedJim to review, thanks! |
Collaborator
|
emmm could you please resolve the confict |
Contributor
Author
done |
Contributor
Author
|
@valarLip could you help review? thanks! |
valarLip
approved these changes
Jan 17, 2026
yzhou103
pushed a commit
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Our build rules uses hipclang to compile .cu files, and normal clang for .cpp files. The .cpp files cpp_itfs all reference ck headers and cannot be compiled with normal clang.
Technical Details
Test Plan
Test Result
Submission Checklist