Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the vLLM benchmark test by correcting the package name used to verify the installation and adding an empty ENTRYPOINT to the generated Dockerfile.
Changes:
- Updated the package name from
aitertoamd-aiterin the post-installation verification step - Added an empty ENTRYPOINT directive to the Dockerfile
Comments suppressed due to low confidence (1)
.github/workflows/vllm_benchmark.yaml:62
- The package name inconsistency creates confusion. Line 61 checks for
aiterand line 62 uninstallsaiter, but line 75 checks foramd-aiterafter installation. Since setup.py defines the package name asamd-aiter, consider updating lines 61-62 to useamd-aiterfor consistency, or verify which package name is actually present in the base image.
RUN echo "=== Aiter version BEFORE uninstall ===" && pip show aiter || true
RUN pip uninstall -y aiter
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yzhou103
pushed a commit
that referenced
this pull request
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.