Skip to content

Comments

CI: Fix vllm benchmark test#1852

Merged
gyohuangxin merged 8 commits intomainfrom
fix_vllm_benchmark_tests
Jan 16, 2026
Merged

CI: Fix vllm benchmark test#1852
gyohuangxin merged 8 commits intomainfrom
fix_vllm_benchmark_tests

Conversation

@gyohuangxin
Copy link
Member

No description provided.

@gyohuangxin gyohuangxin marked this pull request as ready for review January 16, 2026 07:04
@gyohuangxin gyohuangxin requested review from a team and Copilot January 16, 2026 07:04
@gyohuangxin gyohuangxin merged commit 4af0fa8 into main Jan 16, 2026
18 of 19 checks passed
@gyohuangxin gyohuangxin deleted the fix_vllm_benchmark_tests branch January 16, 2026 07:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the vLLM benchmark test by correcting the package name used to verify the installation and adding an empty ENTRYPOINT to the generated Dockerfile.

Changes:

  • Updated the package name from aiter to amd-aiter in the post-installation verification step
  • Added an empty ENTRYPOINT directive to the Dockerfile
Comments suppressed due to low confidence (1)

.github/workflows/vllm_benchmark.yaml:62

  • The package name inconsistency creates confusion. Line 61 checks for aiter and line 62 uninstalls aiter, but line 75 checks for amd-aiter after installation. Since setup.py defines the package name as amd-aiter, consider updating lines 61-62 to use amd-aiter for consistency, or verify which package name is actually present in the base image.
          RUN echo "=== Aiter version BEFORE uninstall ===" && pip show aiter || true
          RUN pip uninstall -y aiter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

yzhou103 pushed a commit that referenced this pull request Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant