Rename .cpp file to .cu for py_itfs_cu#530
Merged
Conversation
Collaborator
|
looks ok for us |
Contributor
Author
|
@valarLip can we merge it if it looks ok to you? :) |
Collaborator
|
yeah.. but we have wait CI finished |
Contributor
Author
|
For sure! |
valarLip
approved these changes
Jun 11, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The files under py_itfs_cu all reference ck headers, and therefore they cannot be compiled by the normal clang, which complains the following:
Our build rules uses hipclang to compile .cu files, and normal clang for .cpp files. So wondering if we can make this change to make our tools easier.