Skip to content

Conversation

@amd-ruitang3
Copy link
Contributor

No description provided.

@valarLip valarLip requested a review from Copilot July 2, 2025 11:31
@valarLip valarLip self-assigned this Jul 2, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds CLI argument support to various test scripts, replacing hard-coded parameters with argparse-driven inputs.

  • Introduce import argparse and argument parsers in each test file
  • Replace static test parameter lists/loops with args.*
  • Update help strings for clarity on expected CLI input

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
op_tests/test_pa_v1.py Added CLI for ctx_len, pa_variant, quant_cache_dtype
op_tests/test_pa_ragged.py Added CLI for ctx_len, pa_variant, quant_cache_dtype
op_tests/test_moe_2stage.py Expanded help text for --quant option
op_tests/test_mla.py Added CLI for dimensions, data types, and batch parameters
op_tests/test_mha_varlen.py Fully parameterized flash-attn varlen test CLI
op_tests/test_kvcache_blockscale.py Added CLI to select which cache tests to run
op_tests/test_kvcache.py Added CLI for quant test selection
op_tests/test_gemm_a8w8_blockscale.py Clarified help text for -m and -nk args
op_tests/test_gemm_a8w8.py Clarified help text for -mnk arg
op_tests/test_gemm_a4w4.py Clarified help text for -s arg
op_tests/test_batched_gemm_bf16.py Clarified help text for -mnk arg
op_tests/test_batched_gemm_a8w8.py Clarified help text for -mnk arg
op_tests/test_activation.py Removed obsolete choices from -m/-n args
op_tests/multigpu_tests/test_custom_allreduce_fp8.py Clarified help text for -s arg
op_tests/multigpu_tests/test_custom_allreduce.py Clarified help text for -s arg
op_tests/multigpu_tests/test_communication.py Clarified help text for -s arg
Comments suppressed due to low confidence (1)

op_tests/test_mla.py:415

  • [nitpick] Argument name --ctxLen uses mixed case. For consistency with other snake_case flags, consider renaming to --ctx_len.
    "--ctxLen",

@valarLip valarLip merged commit 1d9e4f5 into main Jul 7, 2025
13 checks passed
@valarLip valarLip deleted the DIY_mnk_args branch July 7, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants