-
Notifications
You must be signed in to change notification settings - Fork 190
DIY_args #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
DIY_args #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds CLI argument support to various test scripts, replacing hard-coded parameters with argparse-driven inputs.
- Introduce
import argparseand argument parsers in each test file - Replace static test parameter lists/loops with
args.* - Update help strings for clarity on expected CLI input
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| op_tests/test_pa_v1.py | Added CLI for ctx_len, pa_variant, quant_cache_dtype |
| op_tests/test_pa_ragged.py | Added CLI for ctx_len, pa_variant, quant_cache_dtype |
| op_tests/test_moe_2stage.py | Expanded help text for --quant option |
| op_tests/test_mla.py | Added CLI for dimensions, data types, and batch parameters |
| op_tests/test_mha_varlen.py | Fully parameterized flash-attn varlen test CLI |
| op_tests/test_kvcache_blockscale.py | Added CLI to select which cache tests to run |
| op_tests/test_kvcache.py | Added CLI for quant test selection |
| op_tests/test_gemm_a8w8_blockscale.py | Clarified help text for -m and -nk args |
| op_tests/test_gemm_a8w8.py | Clarified help text for -mnk arg |
| op_tests/test_gemm_a4w4.py | Clarified help text for -s arg |
| op_tests/test_batched_gemm_bf16.py | Clarified help text for -mnk arg |
| op_tests/test_batched_gemm_a8w8.py | Clarified help text for -mnk arg |
| op_tests/test_activation.py | Removed obsolete choices from -m/-n args |
| op_tests/multigpu_tests/test_custom_allreduce_fp8.py | Clarified help text for -s arg |
| op_tests/multigpu_tests/test_custom_allreduce.py | Clarified help text for -s arg |
| op_tests/multigpu_tests/test_communication.py | Clarified help text for -s arg |
Comments suppressed due to low confidence (1)
op_tests/test_mla.py:415
- [nitpick] Argument name
--ctxLenuses mixed case. For consistency with other snake_case flags, consider renaming to--ctx_len.
"--ctxLen",
valarLip
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.