Add option to choose between CK RMSNorm pipelines #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cagrikymk
pushed a commit
that referenced
this pull request
Jul 30, 2025
* Add use_model_sensitive_rmsnorm option for rmsnorm * Add op_tests for use_model_sensitive_rmsnorm option * Update ck commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have integrated the new option of
rmsnorm2d_fwd_traitsfrom the CK to support a new RMSNorm pipeline. This commit focuses on this integration, allowing users to select between the new T5-like RMSNorm implementation and the no specific version. This enhancement aims to improve model accuracy while providing flexibility in applying RMS normalization techniques.