Skip to content

Conversation

@valarLip
Copy link
Collaborator

@valarLip valarLip commented Aug 8, 2025

No description provided.

Copilot AI review requested due to automatic review settings August 8, 2025 16:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes formatting and consistency issues in the Python bindings for ROCm operations to resolve test failures in mode 3. The changes focus on cleaning up extra whitespace, improving parameter alignment, and making function definitions more consistent.

  • Removes extraneous empty lines and trailing whitespace
  • Improves parameter alignment and formatting for Python binding definitions
  • Consolidates multi-line function definitions for better readability

Copy link
Collaborator

@carlushuang carlushuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlushuang carlushuang merged commit 829b86b into main Aug 9, 2025
13 of 14 checks passed
@carlushuang carlushuang deleted the fix_rms_norm branch August 9, 2025 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants