-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPI wheel #8
Comments
Hm i think we do something with wheels already. I’ll investigate! |
Yes - not very important but it can be useful to host wheels on PyPI index. |
I think right now we will run into an issue of libamd_smi.so being x86 specific. |
Let us assume user has a ROCM installed already. the PyPI version can detect ROCm using ROCM_PATH and find the libraries it needs. So amdsmi or pyamdsmi can be independent of any ROCm.... This way, even multiple ROCm coexist on the system, it still works very well. |
(Updated Oct. 17th, 2024) It'll be very nice to be able to do NVML also assumes that the user has |
@jaywonchung Thanks for doing that! Some observations:
Correct, and picking ROCm-based releases also makes the most sense. That's part of the confusion with PyPI packaging here too. Do we make dev releases available?
We're not quite ready to take ownership, sorry! We're awaiting migration to github after 6.3 release. We will have more control over our CI tests and packaging. fyi: amdsmi dev happens on internal gerrit and gets mirrored to github overnight Part of the issue - I've never done manylinux compilation 😞 . And we want amdsmi in pypi to run on as many distributions as possible. Also we really don't want it to interfere with a system-wide rocm-based amdsmi install. That would be very confusing.. |
For our particular use case, we're really just aiming to use stable releases of AMDSMI instead of getting nightly. If AMDSMI is planning to release nightly versions per commit or everyday, I think it's better to set up another PyPI project (e.g.,
Right now, the bindings we unofficially distribute is just pure Python, so it's universal. It requires an installation of ROCm under the path designated by Regarding manylinux Python wheel builds, I've never done it myself either but I heard it's more or less just building the wheel inside the manylinux Docker container. It also comes with pre-built images for x64, aarch64, and a few more architectures. PS. Copying @parthraut who did all the actual work. |
ahh I see thanks for the explanation @jaywonchung . Do you think it's better to try and find it in "$ROCM_PATH:-/opt/rocm"? |
Aha, so currently in our bindings,
Yeah, if the user's |
Updated amd-smi set help text --------- Signed-off-by: gabrpham <Gabriel.Pham@amd.com> Signed-off-by: Pham, Gabriel <Gabriel.Pham@amd.com>
Hi,
Having a PyPI wheels for this package would be very useful.
Thank you!
The text was updated successfully, but these errors were encountered: