Skip to content

Handle all combinations of GFXLIST and ROCMLIBS_GFXLIST #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: aomp-dev
Choose a base branch
from

Conversation

saiislam
Copy link
Member

@saiislam saiislam commented May 30, 2025

Couple of boundary conditions were missing where only setting GFXLIST was causing an issue with the sanity checking of architecture list.

ROCMLIBS_GFXLIST defined GFXLIST defined Resulting GFXLIST and ROCMLIBS_GFXLIST
Yes Yes GFXLIST and ROCMLIBS_GFXLIST are both set to their defined values
Yes No GFXLIST is set to ROCMLIBS_GFXLIST, ROCMLIBS_GFXLIST remains unchanged
No Yes ROCMLIBS_GFXLIST is set to GFXLIST, GFXLIST remains unchanged
No No GFXLIST is set to a default list, ROCMLIBS_GFXLIST is set to a smaller subset of GFXLIST

Couple of boundary conditions were missing where only setting GFXLIST was causing an issue with the sanity checking of architecture list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant