Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmake: trunk/llvm-project - Disable sanitizer/fuzzer/prof/xray #500

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Cmake: trunk/llvm-project - Disable sanitizer/fuzzer/prof/xray #500

merged 1 commit into from
Mar 10, 2023

Conversation

dpalermo
Copy link
Contributor

  • Needed due to LLVM_ENABLE_RUNTIMES lists compiler-rt
  • Matches defines currently using in trunk/build_compiler-rt.sh

@dpalermo
Cmake: trunk/llvm-project - Disable sanitizer/fuzzer/prof/xray
83acee9 
  - Needed due to LLVM_ENABLE_RUNTIMES lists compiler-rt
  - Matches defines currently using in trunk/build_compiler-rt.sh
@dpalermo
Copy link
Contributor Author

While doing a clean build_trunk.sh I hit a sanitizer build error on trunk. When I looked, I noticed that we are actually disabling the sanitizer build in build_compiler-rt.sh, but build_project.sh was still building it (since compiler-rt was listed in LLVM_ENABLE_RUNTIMES).

This change just add the existing -DCOMPILER_RT_BUILD_*=OFF defines already in build_compiler-rt.sh to the cmake in build_project.sh.

@dpalermo
Copy link
Contributor Author

Going to go ahead and merge this so no one else does a clean build and end up blocked by the sanitizer build failure upstream.

@dpalermo dpalermo merged commit 02d8d0f into aomp-dev Mar 10, 2023
@dpalermo dpalermo deleted the dp_trunk_0310 branch March 10, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregrodgers gregrodgers Awaiting requested review from gregrodgers gregrodgers is a code owner

@skatrak skatrak Awaiting requested review from skatrak

@jsjodin jsjodin Awaiting requested review from jsjodin

@agozillon agozillon Awaiting requested review from agozillon

@ronlieb ronlieb Awaiting requested review from ronlieb ronlieb is a code owner

@amd-rvilasec amd-rvilasec Awaiting requested review from amd-rvilasec

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dpalermo