[windows] Use is_versioned = true consistently in both Comgr::LoadLib paths. #162
Conversation
… paths. Prior to this, RTCProgram was using is_version = true and device initialization was using false. On Windows, this was causing us to attempt to load amd_comgr_3.dll at device load and amd_comgr0605.dll for RTC programs. Obviously, there is only one DLL and it must be used consistently.
This reverts commit 4b59196. Adds clr patch to use is_versioned consistently (upstreamed as ROCm/clr#162).
This reverts commit 4b59196. Adds clr patch to use is_versioned consistently (upstreamed as ROCm/clr#162).
|
@stellaraccident please see @chrispaquot's comment:
|
hipsdk is actually not the primary windows build system anymore. We should figure out how to support it, but the primary build system that is being used for shipping ROCm on windows is https://github.com/ROCm/TheRock -- and that lays the files out like Linux does, without the driver/app split. We should figure out how to support hipsdk, but we cannot block OSS patches to a proprietary part of the stack that can only be built at AMD. |
(we've been going through and stripping out all cases where the assumption was made that WINDOWS = hipsdk) |
Prior to this, RTCProgram was using is_version = true and device initialization was using false. On Windows, this was causing us to attempt to load amd_comgr_3.dll at device load and amd_comgr0605.dll for RTC programs. Obviously, there is only one DLL and it must be used consistently.