fix: preprocessor directives logic error if/else #1764
+47
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for a bug in the ck profiler code for grouped_gemm_fixed_nk
line 102, 150..
If CK_ENABLE_BF16 or CK_ENABLE_INT8 is not defined and CK_ENABLE_F16 is defined, the code would still compile because it's still syntactically correct due to a preceding if condition for the if/else block.
But the logic breaks.
Couple of ways to solve this that I'm thinking of:
I've implemented the second solution. But we can choose another approach if preferred.