Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ck tile/kvcache #74

Merged
merged 19 commits into from
Aug 28, 2024
Merged

Ck tile/kvcache #74

merged 19 commits into from
Aug 28, 2024

Conversation

rocking5566
Copy link
Collaborator

@rocking5566 rocking5566 commented Aug 19, 2024

Integrate CK's append kv and split kv kernel from this PR
ROCm/composable_kernel#1387

@rocking5566 rocking5566 added the WIP work in progress label Aug 19, 2024
@rocking5566 rocking5566 requested a review from poyenc August 26, 2024 17:05
@rocking5566 rocking5566 removed the WIP work in progress label Aug 28, 2024
@rocking5566 rocking5566 merged commit 7259227 into ck_improve_v0.1.1 Aug 28, 2024
@Cydia2018
Copy link

Thanks for your work, I would like to know when paged kv in "flash_attn_varlen_func" will be supported.

see https://github.com/ROCm/flash-attention/blob/ck_improve_v0.1.1/csrc/flash_attn_ck/mha_varlen_fwd.cpp#L186

@rocking5566
Copy link
Collaborator Author

Thanks for your work, I would like to know when paged kv in "flash_attn_varlen_func" will be supported.

see https://github.com/ROCm/flash-attention/blob/ck_improve_v0.1.1/csrc/flash_attn_ck/mha_varlen_fwd.cpp#L186

This will be supported recently.

@rocking5566 rocking5566 deleted the ck_tile/kvcache branch September 25, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants