Skip to content

Conversation

clintg6
Copy link

@clintg6 clintg6 commented Oct 1, 2025

Summary

This PR updates the Dockerfile to ensure the Micromamba environment is automatically activated when the Docker container is started, without requiring the user to manually run activation commands.

Changes

  • Appended Micromamba shell hook and environment activation to ~/.bashrc.
    • This ensures the environment is active in all interactive shell sessions (e.g., docker run -it).
  • Keeps existing build process and environment creation logic unchanged.

Why?

Previously, users needed to manually activate the Micromamba environment after starting the container:

This update streamlines the user experience by making the environment ready-to-use immediately after container startup.

Test

You can test this by building and running the container interactively:

docker build -f docker/Dockerfile.rocm_ci --target flashinfer_base -t flashinfer-rocm . 2>&1 | tee docker_build.log

and running

docker run -it --network=host --group-add=video \
           --privileged --ipc=host --cap-add=SYS_PTRACE \
           --security-opt seccomp=unconfined --device /dev/kfd \
           --device /dev/dri flashinfer-rocm

Then inside the container, run:

pip show flashinfer
{AF28D7FF-D427-499B-9FAA-1EE2C4F71C9B}

@diptorupd diptorupd requested a review from rtmadduri October 2, 2025 03:26
@demandal25 demandal25 requested review from demandal25 and removed request for demandal25 October 2, 2025 17:46
@diptorupd diptorupd requested a review from Copilot October 3, 2025 19:29
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to auto-activate the Micromamba environment in interactive shells by appending initialization and activation commands to the container’s ~/.bashrc.

  • Append Micromamba shell hook and environment activation to ~/.bashrc
  • Keep existing build and environment creation logic unchanged

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

clintg6 and others added 2 commits October 3, 2025 17:19
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Clint <clintg6@users.noreply.github.com>
@diptorupd
Copy link
Collaborator

@clintg6 I am fine with these changes. Let @rtmadduri have a look once and I will merge it.

@demandal25 demandal25 self-requested a review October 7, 2025 14:27
@diptorupd diptorupd merged commit 47aac38 into amd-integration Oct 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants