Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce KMHACKISA environment variable for ISA-level code injection. #1246

Open
wants to merge 1 commit into
base: clang_tot_upgrade
Choose a base branch
from

Conversation

whchung
Copy link
Collaborator

@whchung whchung commented Aug 20, 2019

When used with -fno-gpu-rdc, this allows applications to inject ISA into
object files. This flag is used for kernel developers to tweak ISA before an
optimization can be devised in the compiler.

The feature is developed for @asroy and @zjing14 . Need verification from their applications first.

When used with -fno-gpu-rdc, this allows applications to inject ISA into
object files. This flag is used for kernel developers to tweak ISA before an
optimization can be devised in the compiler.
Copy link
Collaborator

@scchan scchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should work

@whchung whchung changed the title [DO NOT MERGE] Introduce KMHACKISA environment variable for ISA-level code injection. Introduce KMHACKISA environment variable for ISA-level code injection. Aug 21, 2019
@whchung
Copy link
Collaborator Author

whchung commented Aug 21, 2019

@scchan , @asroy and @zjing14 both could apply the patch onto their projects and do ISA-level tweaking now. Removing [DO NOT MERGE] tag now.

@whchung whchung requested a review from scchan August 23, 2019 15:38
@whchung
Copy link
Collaborator Author

whchung commented Aug 29, 2019

with this PR you are able to inject additional or replace ISA coming out from the compiler.

@whchung
Copy link
Collaborator Author

whchung commented Aug 29, 2019

@scchan This feature is gradually getting picked up by kernel developers in MIOpen team. Wondering could you give this PR another go? Thanks.

@scchan
Copy link
Collaborator

scchan commented Aug 29, 2019

@whchung I'd like to get PR1245 first if possible since it's higher priority. This PR will probably have be updated to adapt to those changes.

Copy link
Contributor

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing old prs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants