Utilize all the cores when building and running tests #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pfultz2 thanks. learnt a new function in CMake. |
whchung
reviewed
Sep 22, 2016
| @@ -28,7 +28,8 @@ ENDIF (NOT CLANG_URL) | |||
| set(CMAKE_MACOSX_RPATH 1) | |||
|
|
|||
| IF (NOT NUM_BUILD_THREADS) | |||
| SET(NUM_BUILD_THREADS 8) | |||
| include(ProcessorCount) | |||
| ProcessorCount(NUM_BUILD_THREADS) | |||
There was a problem hiding this comment.
@pfultz2 Would it make sense if we separate this variable to 2:
- NUM_BUILD_THREADS sets the number of cores used for building HCC
- NUM_TEST_THREADS sets the number of cores used for testing HCC
To my empirical experience, setting NUM_BUILD_THREADS to number of available CPU cores "times 2" yields the best CPU utilization on my build cluster consisting of 3 x86 boxes.
There was a problem hiding this comment.
Yea, it already is two separate variables. The NUM_BUILD_THREADS does not affect the threads for testing. Right now, I just called the variable N, but it does make sense to rename it to NUM_TEST_THREADS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up the cmake to call the 'ProcessorCount' module to build and test with all the cores available, instead of just setting it to 8.